Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check message on completion #672

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Update check message on completion #672

merged 5 commits into from
Dec 16, 2020

Conversation

samuel-w
Copy link
Contributor

Other messages claim to complete without checking the returncode, for example BorgExtractThread. Should we change that?

Fixes #671

@m3nu
Copy link
Contributor

m3nu commented Sep 27, 2020

Good idea. Now that we have 2 areas for status updates, we could add more messages on success/failure based on return code without hiding the last error log message.

@codecov-io
Copy link

codecov-io commented Dec 13, 2020

Codecov Report

Merging #672 (f3f0a97) into master (8814624) will increase coverage by 2.63%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   70.86%   73.49%   +2.63%     
==========================================
  Files          53       53              
  Lines        3504     3505       +1     
==========================================
+ Hits         2483     2576      +93     
+ Misses       1021      929      -92     
Impacted Files Coverage Δ
src/vorta/borg/check.py 70.00% <0.00%> (-3.69%) ⬇️
src/vorta/models.py 81.12% <0.00%> (+0.51%) ⬆️
src/vorta/borg/borg_thread.py 79.28% <0.00%> (+1.77%) ⬆️
src/vorta/config.py 100.00% <0.00%> (+5.55%) ⬆️
src/vorta/network_status/abc.py 88.23% <0.00%> (+5.88%) ⬆️
src/vorta/utils.py 60.86% <0.00%> (+6.52%) ⬆️
src/vorta/keyring/abc.py 88.23% <0.00%> (+8.82%) ⬆️
src/vorta/notifications.py 84.84% <0.00%> (+13.63%) ⬆️
src/vorta/network_status/darwin.py 61.01% <0.00%> (+27.11%) ⬆️
src/vorta/autostart.py 96.96% <0.00%> (+33.33%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8814624...f3f0a97. Read the comment docs.

@m3nu m3nu self-assigned this Dec 15, 2020
@m3nu m3nu merged commit 6d0ef76 into borgbase:master Dec 16, 2020
@samuel-w samuel-w deleted the clear-check branch December 16, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Starting consistency check... doesn't clear the message
3 participants