-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KWallet support #540
Add KWallet support #540
Conversation
Wait, QtDBus exists. Have to change code |
Attempting to port to QtDBus, unsucessful. |
Too bad... |
Tested and it works, woohoo. Had to use command line to get the handle. |
Old commit messages: - Add KWallet 4 and 5 support - Spelling, lint, move comments, remove print - Use PyQt5,QtDBus over dbus, untested - Lint - Use list instead of many args - Open wallet only on password request - Remove noqa - Check if KWallet is enabled
Dont want to add this any more? I’m a bit behind merging PRs due to many other things going on, but plan to catch up over Aug. |
I really would like to get this feature |
Initially closed this because I thought no one would use it, as more code = more maintenance. Guess I was wrong. |
This reverts commit bf49c4b.
Wait a bit, I may have forgot to catch an exception |
For #607, but works without it
KDE 4 is 6 years out of support
More people use secrestservice password maangerse than KWallet
What's the status of this? |
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
- Coverage 74.60% 74.45% -0.15%
==========================================
Files 52 53 +1
Lines 3379 3418 +39
==========================================
+ Hits 2521 2545 +24
- Misses 858 873 +15
Continue to review full report at Codecov.
|
In the future, we should check if the wallet closes in between detecting the current keyring and setting the password.
Also, is there an alternate way to do keyring detection other than a mountain of try excepts? The code is starting to get hard to read.
Fixes #236