Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a checkbox for mount option override, fixes #520 #522

Closed
wants to merge 5 commits into from
Closed

Adds a checkbox for mount option override, fixes #520 #522

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2020

There are 3 issues with this pull:

  1. Adding the checkbox adds clutter to the UI
  2. What should the default setting should be, as either setting can break permissions, see Override permissions for borg mount #362 and Use different permissions when mounting archive. #520.
  3. Does the average user knows what mount permissions are? Possible solution would be add a tooltip along the likes of "Toggle this if any permission denied errors pop up".
    I'd like some input before going further, mostly on issue 2

@ghost
Copy link
Author

ghost commented Jun 19, 2020

After thinking about it, I think the default behaviour should be more like unmodified borg mount command, so I'll make the checkbox unticked by default

samuel-w added 2 commits June 19, 2020 13:10
To more closely follow default `borg mount` behaviour
@ghost ghost marked this pull request as ready for review June 23, 2020 01:49
@ghost
Copy link
Author

ghost commented Jun 29, 2020

Not sure if its state should be saved or not.

@samuel-w
Copy link
Contributor

samuel-w commented Jul 2, 2020

Also closes #436

@samuel-w
Copy link
Contributor

samuel-w commented Oct 7, 2020

Replaced by #682

@samuel-w samuel-w closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant