Implement experimental pattern support. Fixes borgbase/vorta#378 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
|
This is a larger change and may need some discussion. I'll test it a bit over the next days. |
|
There is a big overlap with the patterns we already support and users are already complaining that this tab is too complicated. I'd rather Readme for this Borg feature: https://borgbackup.readthedocs.io/en/stable/usage/help.html Before adding this, I'd rather work on additional exclude improvements as discussed in #399 and then hide those advanced options in a QToolbox (as we do in the Archive tab) |
|
Since the branch and the commits are lost, I'll close this. Work on the exclude pattern GUI is currently tracked in #907. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.