PR: Complete Unit Test cleanup/parametrization/coverage increases #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtedde
commented
Aug 31, 2023
src/vorta/views/repo_tab.py
Outdated
| @@ -198,8 +198,7 @@ def create_ssh_key(self): | |||
| ssh_add_window = SSHAddWindow() | |||
| self._window = ssh_add_window # For tests | |||
| ssh_add_window.setParent(self, QtCore.Qt.WindowType.Sheet) | |||
| ssh_add_window.accepted.connect(self.init_ssh) | |||
| # ssh_add_window.rejected.connect(lambda: self.sshComboBox.setCurrentIndex(0)) | |||
| ssh_add_window.rejected.connect(self.init_ssh) | |||
There was a problem hiding this comment.
This fixes a bug I found during testing. Before, the SSH Key selector was not repopulating with new keys until Vorta was restarted. Now, it will repopulate whenever the user closes ssh_add_window
|
@m3nu @real-yfprojects with these additional tests, coverage now sits at 80% 🎉 Marking as ready for review 👍
|
m3nu
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Putting the finishing touches on the unit test folder. Some remaining code cleanup, parametrization, and additional tests where needed.
Related Issue
#1754
Motivation and Context
One of my Google Summer of Code projects involves cleaning up the Vorta tests, reducing duplicated code, and increasing code coverage.
How Has This Been Tested?
Locally, and passes the automated Github test workflow.
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.