PR: tests/unit/test_source: cleanup, parametrize, and increase test coverage
#1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtedde
commented
Aug 10, 2023
tests/unit/test_source.py
Outdated
| qtbot.waitUntil(lambda: tab.sourceFilesWidget.rowCount() == 2, **pytest._wait_defaults) | ||
| assert tab.sourceFilesWidget.rowCount() == 2 | ||
| # Wait for directory sizing to finish | ||
| qtbot.waitUntil(lambda: len(qapp.main_window.sourceTab.updateThreads) == 0, **pytest._wait_defaults) |
There was a problem hiding this comment.
This line is causing problems with the linux tests most of the time, but not always. Never seems to have trouble on darwin. Might need to do more digging here. @m3nu @real-yfprojects have either of y'all encountered errors caused by updateThreads before?
Specifically, updateThreads is not not getting set back to 0 and the wait times out.
There was a problem hiding this comment.
Resolved - this needs to be called after each test. Moved to fixture teardown.
bigtedde
commented
Aug 10, 2023
| yield main, tab | ||
|
|
||
| # Wait for directory sizing to finish | ||
| qtbot.waitUntil(lambda: len(qapp.main_window.sourceTab.updateThreads) == 0, timeout=2000) |
There was a problem hiding this comment.
After some digging, I discovered this wait needs to be done after each source test that involves updateThreads. I added this to the source_env fixture to happen at teardown.
m3nu
previously approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I cleaned up the
test_sourcemodule by splitting thepaste_text()testing into its own separate test. I then parametrizedtest_paste_text()to cover more use/edge cases. Finally, I added in tests for removing a source from the sources table, as well as testing the source update button.Related Issue
#1754
Motivation and Context
One of my Google Summer of Code projects involves cleaning up the Vorta tests, reducing duplicated code, and increasing code coverage.
How Has This Been Tested?
Tests work locally by running
pytest, and they pass the GitHub CI checks.Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.