PR: tests/unit/test_repo - Clean up, parametrize, and increase test coverage.
#1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtedde
commented
Aug 9, 2023
| @@ -69,8 +73,9 @@ def test_repo_unlink(qapp, qtbot, monkeypatch): | |||
|
|
|||
| def test_password_autofill(qapp, qtbot): | |||
| main = qapp.main_window | |||
| main.repoTab.new_repo() # couldn't click menu | |||
| add_repo_window = main.repoTab._window | |||
| tab = main.repoTab | |||
There was a problem hiding this comment.
For consistency across the tests, I defined main and tab in each test that used them.
bigtedde
commented
Aug 9, 2023
| @@ -138,7 +138,7 @@ def validate(self) -> bool: | |||
| self.passwordLineEdit.error_state = True | |||
| self.confirmLineEdit.error_state = True | |||
| self.set_error_label( | |||
| translate('PasswordInput', "Passwords must be identical and atleast {0} characters long.").format( | |||
| translate('PasswordInput', "Passwords must be identical and at least {0} characters long.").format( | |||
There was a problem hiding this comment.
Typo corrected: 'atleast' -> 'at least'
bigtedde
commented
Aug 9, 2023
| @@ -107,7 +107,7 @@ def validate(self): | |||
| return False | |||
|
|
|||
| if len(self.values['repo_name']) > 64: | |||
| self._set_status(self.tr('Repository name must be less than 64 characters.')) | |||
| self._set_status(self.tr('Repository name must be less than 65 characters.')) | |||
There was a problem hiding this comment.
Corrected wording, should say "less than 65 characters" or "no more than 64 characters". I chose the path of least change.
m3nu
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The repo unit test module has some areas of opportunity for clean up, test parameterization, and additional test coverage.
I have cleaned up the tests by separating
test_repo_add_failuresintotest_new_repo_password_validationandtest_repo_add_failuresas these seems to be more clear indications of what was being tested. Additionally, I parametrized the password validation tests to reduce code duplication.I added a new test for repo name behavior and parametrized it to test a few inputs. When adding this test, I noticed a typo in the
validate()function ofRepoWindowclass that I fixed.Related Issue
#1754
Motivation and Context
One of my Google Summer of Code projects involves cleaning up the Vorta tests, reducing duplicated code, and increasing code coverage.
How Has This Been Tested?
Tests work locally by running pytest, and they pass the GitHub CI checks.
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.