Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyobjc imports, bump minimum Python version #1698

Merged
merged 5 commits into from
Apr 29, 2023
Merged

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Apr 17, 2023

Description

Moved pyobjc imports to modul level, since lazy imports would cause a segfault starting with version 9.1
Also set minimum Python version to 3.8 and removed pinning of GH Action's Python action.

Related Issue

Fixes #1695

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@m3nu m3nu force-pushed the pyobjc-91 branch 4 times, most recently from 278cf43 to 8e8171c Compare April 17, 2023 20:49
@real-yfprojects real-yfprojects linked an issue Apr 17, 2023 that may be closed by this pull request
@m3nu m3nu marked this pull request as ready for review April 18, 2023 07:26
@m3nu m3nu requested a review from real-yfprojects April 18, 2023 07:31
@m3nu m3nu changed the title Unpin pyobjc (WIP) Fix pyobjc imports, bump minimum Python version Apr 18, 2023
@m3nu m3nu merged commit 4d65912 into borgbase:master Apr 29, 2023
DaffyTheDuck pushed a commit to DaffyTheDuck/vorta that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyobjc 9.1 Segfault
2 participants