Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up vorta/models.py #1112

Merged
merged 4 commits into from
Nov 17, 2021
Merged

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Nov 16, 2021

This splits up vorta.models and puts it in a package vorta.store.

Fixes #937

@m3nu m3nu requested a review from bastiencyr November 16, 2021 07:43
@m3nu
Copy link
Contributor Author

m3nu commented Nov 16, 2021

Maybe this will also help for the modular refactoring, @bastiencyr .

@bastiencyr
Copy link
Collaborator

bastiencyr commented Nov 16, 2021

It can because models mixes different features (migration, models).
But you want to try the module structure so ? Starting with a little experimental implementation ?
Because modules dont change current code in his first implementation or even interact with, we dont need to wait a major version (vorta 0.9 for example).

@m3nu
Copy link
Contributor Author

m3nu commented Nov 16, 2021

Yes, splitting this up will help you with the modular design, I hope. We had too many things in vorta.models.

Starting small is always good. I still have a hard time imagining the changes.

@m3nu m3nu merged commit 4c3e97a into borgbase:master Nov 17, 2021
@m3nu m3nu deleted the issue/937/split-models.py branch November 17, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Split up vorta/models.py
2 participants