Always handle autosave setting when saving SettingsModel (fixes #1092) #1093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092 - This PR attempts to fix the autostart setting not being set correctly when importing. I deliberately chose not to duplicate the code from the misc tab to the init_db function. Instead I tried to keep it DRY and use signals from Pewee. This has the advantage that is does not matter where the SettingsModel is saved - the autostart is always set up afterwards.
This is only a suggestion how to fix it and I know that this is a bit different from an architectural point of view. We basically pull logic from a view to the models. I am always open to a different approach.