Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip containing path name #1072

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add tooltip containing path name #1072

merged 1 commit into from
Oct 13, 2021

Conversation

XXXBold
Copy link
Contributor

@XXXBold XXXBold commented Oct 6, 2021

Minor improvement, avoiding situations which might lead to path names not readable because they're too long (Or vorta-window too small):
added-tooltip

@bastiencyr
Copy link
Collaborator

Hello @XXXBold ,
Thanks for the contribution <3
Tooltips should be avoid if possible (tooltip not printed in touchscreen, see #1050). However I don't see other simple solution and this tooltip doesn't give essential info. Another solution is to scroll the text when item is selected.
So its ok for me. Lets wait the maintainer 😁

@XXXBold
Copy link
Contributor Author

XXXBold commented Oct 8, 2021

Hi @bastiencyr
Thanks for the feedback.
It might be true that tooltips are not helpful on a touchscreen, but I implemented this behaviour because it's common practice in most software I know.
I don't think there are much people out there using vorta on a touch screen either, because most parts of the UI aren't suitable for that anyway.

@bastiencyr
Copy link
Collaborator

bastiencyr commented Oct 9, 2021

Hi @bastiencyr Thanks for the feedback. It might be true that tooltips are not helpful on a touchscreen, but I implemented this behaviour because it's common practice in most software I know. I don't think there are much people out there using vorta on a touch screen either, because most parts of the UI aren't suitable for that anyway.

What is important is to not abuse them and not give essential information and it's fine for this tooltip 🤗. I just quoted the HIG of Gnome.

Most part ?
Even if Vorta is not suitable for touchscreen, It's not a reason to continue. It's just that nobody has considered this before ☹

@XXXBold
Copy link
Contributor Author

XXXBold commented Oct 9, 2021

Even if Vorta is not suitable for touchscreen, It's not a reason to continue.

Sure, don't get me wrong, you may ofc use it this way. I'm just pretty sure that the current interest in touch screens is low (aside from mobile devices like smart phones).

It's just that nobody has considered this before

Well, I think this might gain attention if for example Android or other mobile systems get support from borgbackup :)

@m3nu
Copy link
Contributor

m3nu commented Oct 13, 2021

We use tooltips in a few places. They are mainly set in UI files for now. They aren't great, but work as fallback. So let's add it.

There is also a related idea to remove the type column #1074 . Should give some more space.

@m3nu m3nu merged commit 9919070 into borgbase:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants