Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty files don't show size in extract dialog, and are sorted incorectly. #915

Closed
rblenis opened this issue Mar 4, 2021 · 2 comments
Closed

empty files don't show size in extract dialog, and are sorted incorectly. #915

rblenis opened this issue Mar 4, 2021 · 2 comments
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it priority:low Nice to have feature, minor improvement to functionality or usability type:bug Something doesn't work as intended
Milestone
v0.10.x (Next min...

Comments

@rblenis
Copy link
Contributor

rblenis commented Mar 4, 2021

  1. create an archive with some empty files (size==0)
  2. select archive and click 'extract'
  3. expand tree view to see files
  4. notice that empty files are sorted at the top (with directories), and size field is blank
  • OS: Ubuntu 20.10
  • Vorta version: 0.7.5
  • Installed from: snap
@m3nu m3nu added priority:low Nice to have feature, minor improvement to functionality or usability type:bug Something doesn't work as intended labels Mar 4, 2021
@m3nu
Copy link
Contributor

m3nu commented Mar 12, 2021

Interesting. Will try to reproduce this.

@m3nu
Copy link
Contributor

m3nu commented Apr 9, 2021

Was able to reproduce this as well. Empty files end up on top of folders.

I believe they should show up with 0B together with other files.

Screen Shot 2021-04-09 at 11 38 53 PM

@m3nu m3nu added this to the v0.7.6 (Next minor release) milestone Apr 9, 2021
@m3nu m3nu added good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it labels Apr 9, 2021
bastiencyr added a commit to bastiencyr/vorta that referenced this issue May 28, 2021
@bastiencyr
Fix for borgbase#915 . Folder ares sorted with type.
5e6dc08
@bastiencyr bastiencyr mentioned this issue May 28, 2021
Merged
bastiencyr added a commit to bastiencyr/vorta that referenced this issue May 29, 2021
@bastiencyr
Fix for borgbase#915 . Pass 2 tests more with archives diff.
c261b1f
@m3nu m3nu closed this as completed in 292066f May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it priority:low Nice to have feature, minor improvement to functionality or usability type:bug Something doesn't work as intended
Projects
None yet
Milestone
v0.10.x (Next minor release)
Development

No branches or pull requests
2 participants
@m3nu @rblenis