-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify requirements when using command line options with special characters within a shell #8628
Conversation
Clarify docs: Within a shell, command line options with special characters require adjustments, such as quotation marks. borgbackup#8578
Some check were not successful - but I don't understand the underlying issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8628 +/- ##
==========================================
- Coverage 81.83% 81.82% -0.02%
==========================================
Files 74 74
Lines 13319 13348 +29
Branches 1963 1971 +8
==========================================
+ Hits 10900 10922 +22
- Misses 1755 1761 +6
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! |
maybe we want a backport of this to 1.4. |
In GitHub, if I switch to branch 1.4-maint I can not find the file src/borg/archiver/help_cmd.py This could be me, doing something stupid/ not understanding some fundamental principles of git/ GitHub. |
I think I found the corresponding file with the help text in branch 1.4.: Sorry for the noise - I will send a pull request for branch 1.4. |
…ial characters within a shell borgbackup#8628 docs: clarify requirements when using command line options with special characters within a shell borgbackup#8628 port to the 1.4-maint branch
@goebbe the file structure between 1.x and master is a bit different. in 1.x, we had a huge archiver.py file with code for all commands inside. that was split into an archiver package with 1 file per command / per few related commands. |
docs: clarify requirements when using command line options with special characters within a shell #8628
Clarify docs:
Within a shell, command line options with special characters require adjustments, such as quotation marks.
#8578