Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify requirements when using command line options with special characters within a shell #8628

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

goebbe
Copy link
Contributor

@goebbe goebbe commented Jan 10, 2025

Clarify docs:
Within a shell, command line options with special characters require adjustments, such as quotation marks.
#8578

Clarify docs: 
Within a shell, command line options with special characters require adjustments, such as quotation marks. 
borgbackup#8578
@goebbe
Copy link
Contributor Author

goebbe commented Jan 10, 2025

Some check were not successful - but I don't understand the underlying issue.
I hope this is not caused by this pull request.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/borg/archiver/help_cmd.py Outdated Show resolved Hide resolved
src/borg/archiver/help_cmd.py Outdated Show resolved Hide resolved
src/borg/archiver/help_cmd.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (1559a1e) to head (1cb9c19).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8628      +/-   ##
==========================================
- Coverage   81.83%   81.82%   -0.02%     
==========================================
  Files          74       74              
  Lines       13319    13348      +29     
  Branches     1963     1971       +8     
==========================================
+ Hits        10900    10922      +22     
- Misses       1755     1761       +6     
- Partials      664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ThomasWaldmann ThomasWaldmann merged commit 4832364 into borgbackup:master Jan 11, 2025
13 of 14 checks passed
@ThomasWaldmann
Copy link
Member

Thanks!

@ThomasWaldmann
Copy link
Member

maybe we want a backport of this to 1.4.

@goebbe
Copy link
Contributor Author

goebbe commented Jan 13, 2025

maybe we want a backport of this to 1.4.

In GitHub, if I switch to branch 1.4-maint I can not find the file src/borg/archiver/help_cmd.py
Actually, using the file GitHub file search, I could not even find a file named help_cmd.py in this branch.
Where can I find the internal docs for 1.4.?

This could be me, doing something stupid/ not understanding some fundamental principles of git/ GitHub.
Any advice or hint is welcome.

@goebbe
Copy link
Contributor Author

goebbe commented Jan 13, 2025

I think I found the corresponding file with the help text in branch 1.4.:
borg/src/borg/archiver.py
line 2310: helptext['patterns'] = textwrap.dedent('''

Sorry for the noise - I will send a pull request for branch 1.4.

goebbe added a commit to goebbe/borg1.4 that referenced this pull request Jan 13, 2025
…ial characters within a shell borgbackup#8628

docs: clarify requirements when using command line options with special characters within a shell borgbackup#8628 

port to the 1.4-maint branch
@ThomasWaldmann
Copy link
Member

@goebbe the file structure between 1.x and master is a bit different.

in 1.x, we had a huge archiver.py file with code for all commands inside. that was split into an archiver package with 1 file per command / per few related commands.

ThomasWaldmann added a commit that referenced this pull request Jan 13, 2025
docs: clarify requirements when using command line options with special characters within a shell #8628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants