Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify user_id vs uid for fuse #5958

Merged
merged 6 commits into from Aug 25, 2021
Merged

docs: clarify user_id vs uid for fuse #5958

merged 6 commits into from Aug 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2021

Fixes: #5723

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #5958 (5d6e9c8) into master (c6559f0) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5958      +/-   ##
==========================================
- Coverage   83.32%   83.10%   -0.23%     
==========================================
  Files          38       38              
  Lines       10359    10359              
  Branches     1710     1710              
==========================================
- Hits         8632     8609      -23     
- Misses       1221     1238      +17     
- Partials      506      512       +6     
Impacted Files Coverage Δ
src/borg/archiver.py 80.26% <ø> (ø)
src/borg/platform/__init__.py 72.00% <0.00%> (-12.00%) ⬇️
src/borg/platform/base.py 77.77% <0.00%> (-3.42%) ⬇️
src/borg/helpers/misc.py 77.34% <0.00%> (-1.66%) ⬇️
src/borg/helpers/fs.py 85.52% <0.00%> (-1.32%) ⬇️
src/borg/xattr.py 49.41% <0.00%> (-1.18%) ⬇️
src/borg/archive.py 81.46% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6559f0...5d6e9c8. Read the comment docs.

@ghost
Copy link
Author

ghost commented Aug 24, 2021

PTAL.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some grammar nitpicks and one thing that is still unclear.

src/borg/archiver.py Outdated Show resolved Hide resolved
src/borg/archiver.py Outdated Show resolved Hide resolved
src/borg/archiver.py Outdated Show resolved Hide resolved
src/borg/archiver.py Outdated Show resolved Hide resolved
@ThomasWaldmann ThomasWaldmann merged commit 795d9ab into borgbackup:master Aug 25, 2021
@ThomasWaldmann
Copy link
Member

Thanks!

This was referenced Aug 25, 2021
ThomasWaldmann added a commit that referenced this pull request Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

borg mount: Permissions errors despite seemingly correct mount options
3 participants