-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest deprecation warning about yield_fixture #5575
Comments
I've seen this in master branch, but guess it also applies to 1.1-maint. |
/vagrant/borg/borg/.tox/py36-none/lib/python3.6/site-packages/borg/testsuite/remote.py:73: PytestDeprecationWarning: @pytest.yield_fixture is deprecated. Use @pytest.fixture instead; they are the same. Docs: https://docs.pytest.org/en/stable/warnings.html
…ation use pytest.fixture instead of yield_fixture, fixes #5575
…ation-master use pytest.fixture instead of yield_fixture, fixes #5575 (master)
Just wanted to note that this makes it harder to ship borgbackup in EPEL 7 as we have pytest 2.9.2 there. Not a big deal to create a patch for this issue but I hope we can keep using pytest 2.9 for some time. |
OK, so we need to revert #5577 and:
OTOH: 1.1.15 is already out, so @FelixSchwarz needs to patch anyway? |
I already added a revert manually: https://src.fedoraproject.org/rpms/borgbackup/tree/epel7 Also I don't think you have to revert this patch upstream. This is a patch with a straight-forward revert which I can carry for EPEL7. Of course official support for pytest 2.9 would be a bit easier but I don't want to place an unreasonable burden on upstream development. |
OK, so we'll keep it as is. Thanks for patching. |
pytest 6.2.1:
This should be fixed globally.
The text was updated successfully, but these errors were encountered: