Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo-playdate error "No packages has been produced" #323

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

boozook
Copy link
Owner

@boozook boozook commented Apr 22, 2024

Fix #315 "No packages has been produced", caused because cargo changed artefact name format - now replaces dashes with underscores for libs too.

Related cargo PR is rust-lang/cargo#12783 which landed will land in Cargo 1.79 (2024-06-13) according to CHANGELOG.

It's definitely not a perfect solution, it's just a hot-fix. It should be refactored in the near future.

…d artefact name format - now replaces dashes with underscores for libs too.
@boozook boozook added bug Something isn't working cargo About cargo or cargo-playdate compatibility labels Apr 22, 2024
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
cargo/tests/build/simple.rs Outdated Show resolved Hide resolved
clippy suggestions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@paulyoung
Copy link
Contributor

This appears to fix #315 for me. Thanks @boozook!

@boozook
Copy link
Owner Author

boozook commented Apr 24, 2024

Thanks!
Then I merge it now.

@boozook boozook merged commit a390d03 into main Apr 24, 2024
26 checks passed
@boozook boozook deleted the cargo-fix-no-products-315 branch April 24, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cargo About cargo or cargo-playdate compatibility
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

error: No packages has been produced, nothing to run.
2 participants