Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub from enterprise #22

Merged
merged 10 commits into from
Jun 13, 2019
Merged

GitHub from enterprise #22

merged 10 commits into from
Jun 13, 2019

Conversation

cokieffebah
Copy link
Contributor

@cokieffebah cokieffebah commented Jun 6, 2019

PR Details

Description

How Has This Been Tested

pipeline-config: cokieffebah/sdp-ex-libraries:{ branch:master, configBaseDir:github-library}
scm:github: boozallen/sdp-labs-sample-app:{ branch:github-library }

did a PR, for basic github, boozallen/sdp-labs-sample-app/pull/2, to: github-library, from: github-lib-pr
did a PR, for github enterprise, https://github.boozallencsn.com/O-Kieffe-Carlos/sdp-labs-sample-app/pull/1, using copies of the above branches from boozallen/sdp-labs-sample-app

Types of Changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have updated the Change Log appropriately.

@cokieffebah cokieffebah self-assigned this Jun 6, 2019
Copy link
Contributor

@kottoson kottoson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did a quick tests and updated the README

@kottoson kottoson merged commit 90f7ae5 into master Jun 13, 2019
@cokieffebah cokieffebah deleted the github-from-enterprise branch June 13, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants