Rework announcements to not use global SHARED object #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
SHARED.announcer
is gone, as isstore.queuedAnnouncements
andstore.muteAnnouncements
mountAnnouncer()
function that encapsulates initialization of dom nodes and announcer stateAnnouncer
class that encapsulates state/semantics around the announcement queuemuteAnnouncements
altogether since it didn't appear to ever be set to anything butfalse
We're still relying on the correct order of operations to be used in that
mountAnnouncer()
must be called beforesay()
will do anything, but at least now it's documented. I'm not sure why the dom node that holds the announcements needs to be inside the element that wraps the codemirror editor, but if it doesn't, then we could just add it todocument.body
instead and we would no longer needmountAnnouncer
.