Support for i18n :html subkeys in help text #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcreid
approved these changes
Mar 20, 2018
There was a problem hiding this comment.
Thanks for the contribution! This is a nice first contribution! Everything looks fine to me. I'll ask @mattbrictson to take a quick look at this and we should be able to merge it soon.
|
Hi, @lcreid ! It is possible that the change could benefit from some small refactoring, but I opted to keep it as simple as possible, for now. |
|
@jsaraiva that was the right call. At the moment, we're just trying to make this work for Bootstrap 4, with minimal code changes. Thanks again! |
|
@jsaraiva thanks, and congrats on your first contribution to the project! I will merge this in. |
xire28
pushed a commit
to xire28/bootstrap_form
that referenced
this pull request
Mar 30, 2018
* Support for i18n :html subkeys in help text * added info to changelog, as per bot instructions * Tweak changelog
lcreid
pushed a commit
to lcreid/rails-bootstrap-forms
that referenced
this pull request
Jun 4, 2018
* Support for i18n :html subkeys in help text * added info to changelog, as per bot instructions * Tweak changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for help text using :html subkey instead of the "_html" suffix to the attribute name.
Both are supported by i18n, actually: http://guides.rubyonrails.org/i18n.html#using-safe-html-translations .
This code just makes an additional check for an html subkey. If none is found, it continues in the regular fashion.