Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5 Support #269

Closed
wants to merge 8 commits into from
Closed

Rails 5 Support #269

wants to merge 8 commits into from

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented Jun 7, 2016

With Rails 5 around the corner, I've removed deprecated functions, and made use of new functionality like Module#prepend.

EDIT

Oh well, it seems I overlooked some other PR's. (namely #267 #248)

@beydogan
Copy link

beydogan commented Jun 10, 2016

Thanks, I was looking for this!

For those who want to use it, it can be used by adding following line to your gemfile;

gem "bootstrap_form", github: "fetch/rails-bootstrap-forms", branch: "rails-5"

@mattbrictson
Copy link
Contributor

@koenpunt Since #267 has been merged, can we close this PR? If there is more needed to support Rails 5, let me know and I'll do my best to review and merge it in. Thanks!

@koenpunt
Copy link
Contributor Author

koenpunt commented Jul 4, 2016

No, your branch was sufficient, thanks!

@koenpunt koenpunt closed this Jul 4, 2016
@koenpunt koenpunt deleted the rails-5 branch July 4, 2016 20:40
@koenpunt
Copy link
Contributor Author

koenpunt commented Jul 4, 2016

Although, if the test/dummy application gets updated to rails 5, my updated specs could come in handy

@mattbrictson
Copy link
Contributor

if the test/dummy application gets updated to rails 5, my updated specs could come in handy

@koenpunt OK, can you make a note of that in issue #273? Thanks!

@koenpunt koenpunt restored the rails-5 branch July 4, 2016 20:58
@koenpunt
Copy link
Contributor Author

koenpunt commented Jul 4, 2016

Turns out I was too quick with saying all was fine, because I didn't update my Gemfile yet, and it was still using a GitHub source.

When I use the bundled gem again, my tests produce a lot of errors, although I'm not sure what's causing them exactly, so will have to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants