Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set -e #874

Merged
merged 1 commit into from
Oct 28, 2024
Merged

docs: set -e #874

merged 1 commit into from
Oct 28, 2024

Conversation

sdarwin
Copy link
Collaborator

@sdarwin sdarwin commented Oct 28, 2024

Running build_antora.sh in CI jobs there is no way of ascertaining if it failed since the last command is

echo "Done"

which always returns 0. A solution could be to move npx antora as the last command, so its exit code will be the same as the script itself. Or enable the bash setting "Exit immediately if a command exits with a non-zero status."

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://874.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (d8cacb5) to head (d136947).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #874   +/-   ##
========================================
  Coverage    99.20%   99.20%           
========================================
  Files          157      157           
  Lines         8415     8415           
========================================
  Hits          8348     8348           
  Misses          67       67           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cacb5...d136947. Read the comment docs.

@alandefreitas alandefreitas merged commit 3915041 into boostorg:develop Oct 28, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants