Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore -Wnonnull new gcc 11 warnings. #28

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

Romain-Geissler-1A
Copy link
Contributor

I don't know if ignoring this error the actual good thing to do (since I am unclear your intend actually is in this code), anyway, this should silence the warnings as reported in issue #27.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #28 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8cf003...2ec6dc0. Read the comment docs.

@mclow mclow merged commit affc79e into boostorg:develop Mar 4, 2021
zaucy pushed a commit to bazelboost/concept_check that referenced this pull request Jun 3, 2021
DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Nov 16, 2023
this patch fixes errors like:

```
nclude/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28
DeckerSU added a commit to DeckerSU/komodo that referenced this pull request Nov 16, 2023
this patch fixes errors like:

```
include/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28
DeckerSU added a commit to KomodoPlatform/komodo that referenced this pull request Nov 16, 2023
this patch fixes errors like:

```
include/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28

# Conflicts:
#	depends/packages/boost.mk
DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Nov 16, 2023
this patch fixes errors like:

```
include/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28
DeckerSU added a commit to DeckerSU/komodo that referenced this pull request Nov 21, 2023
this patch fixes errors like:

```
include/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28
DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Nov 21, 2023
this patch fixes errors like:

```
include/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28
DeckerSU added a commit to DeckerSU/komodo that referenced this pull request Nov 22, 2023
this patch fixes errors like:

```
include/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28
TheComputerGenie added a commit to DigitalPrice/DP-Wallet that referenced this pull request Jan 5, 2024
fixes 'ERROR: ConnectBlock: ac_staked chain failed slow komodo_checkPOW' among other things

squashed 00f8aa...820b99

add zk-SNARK proofs related comments

zmq: Fix due to invalid argument and multiple notifiers

fix value pools calculations (#63)

KomodoPlatform/komodo#604
depends: patch boost to ignore -Wnonnull new gcc 11 warnings (#64)

this patch fixes errors like:

```
include/boost/concept/detail/general.hpp:39:47: warning: 'this' pointer null [-Wnonnull]
   39 |     static void failed() { ((Model*)0)->~Model(); }
```

during build with gcc 11.x, more details can be found here:

- boostorg/concept_check#27
- boostorg/concept_check#28
build: proper clean of ./src/qt/qrc_*.cpp in clean-help

Add chain supply and transparent value to block index.

Co-authored-by: Jack Grigg <jack@z.cash>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>

bump version [0.8.1.3]

from 0.8.1.3 diskblockindex have new fields, related to chain
supply caused by this block and delta in the transparent pool produced
by the action of the transparent inputs to and outputs from
transactions in this block.

See the: TRANSPARENT_VALUE_VERSION constant.

fix transparent pool addition for unspendable outputs

chain.h: change std::nullopt to boost::none in comments

introduce burned coins value pool

burned coins refer to the value sent for OP_RETURN scripts:
```
"vout": [
...
    {
      "value": 2.00000000,
      "valueZat": 200000000,
      "n": 1,
      "scriptPubKey": {
        "asm": "OP_RETURN 6465636b6572",
        "hex": "6a066465636b6572",
        "type": "nulldata"
      }
    }
  ],
  "vjoinsplit": [
  ]
```
burned coins are also excluded from transparent pool.

bump version [0.8.1.4]

this update activates burned coins value pool, see: BURNED_VALUE_VERSION

revert fMiningRequiresPeers change on CMainParams

The change was made solely for debugging purposes and was
accidentally included in the PR. We are now reverting that change.

remove unused CompareBlocksByHeightMain comparator

bump COPYRIGHT_YEAR to 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants