-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 은하 색상 변경 #300
Merged
Merged
[FE] 은하 색상 변경 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 이미지 사이즈 축소 - margin값 조정
- home 카메라 포지션 변경
- 은하 색 변경 - 은하 별 갯수 축소
- nickName이 불러와지기 전에 api 호출되는 것을 막음
- 로그인창의 둘러보기를 예시 은하 구경하기 버튼으로 변경
- 공유링크 이상하게 뜨는 문제 해결
KimGaeun0806
added
✨ Feature
기능 개발
🎨 HTML&CSS
마크업 & 스타일링
🐛 BugFix
에러 해결
FE
프론트엔드
labels
Dec 10, 2023
너무.. 보랏빛이 도는 것 같기도 하고요? 좀 더 흰색인게 좋으려나요 |
MinboyKim
previously approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨어요 전 보라색도 이쁜 것 같습니다!
bananaba
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
galaxy api 오류 해결 완료됐습니다
bananaba
previously approved these changes
Dec 10, 2023
- 닉네임 없이 링크를 요청하지 않도록 수정했다
bananaba
approved these changes
Dec 10, 2023
MinboyKim
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📎 이슈번호
📃 변경사항
은하의 색을 변경했습니다.
은하의 별 개수를 6000개에서 4000개로 변경했습니다.
처음 우주에 도착했을 때의 카메라 position을 변경했습니다.
글쓰기 모달 디자인 변경
api 호출에서 에러나는 부분을 해결했습니다.
nickName이 결졍되기 전에 api가 호출되는 부분이 있어서, nickName이 falsy한 값일 때는 실행되지 않도록 했습니다.
로그인 모달에 '예시 은하 구경하기' 버튼을 추가했습니다.
공유링크 에러를 해결했습니다.
🫨 고민한 부분
📌 중점적으로 볼 부분
🎇 동작 화면
💫 기타사항