Refactor #204: mock repository와 controller로 분리하기 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATeals
previously approved these changes
Dec 4, 2024
Comment on lines
23
to
30
| protected paginate(items: Identifiable<T>[], page: number, size: number) { | ||
| const start = (page - 1) * size; | ||
| const end = start + size; | ||
| const data = items.slice(start, end); | ||
| const maxPage = Math.ceil(items.length / size); | ||
| return { data, maxPage }; | ||
| } | ||
|
|
Comment on lines
20
to
39
| async search({ query, page = 1, size = 10 }: { query?: Partial<LotusDto>; page?: number; size?: number }) { | ||
| const filtered = query ? this.memory.filter((item) => this.isPartialMatch(item, query)) : this.memory; | ||
|
|
||
| return this.paginate(filtered, page, size); | ||
| } | ||
|
|
||
| async findLotusDetail(query: Partial<LotusDto>) { | ||
| const lotus = await lotusRepository.findOne(query); | ||
|
|
||
| return { ...lotus, ...lotusMockFileData }; | ||
| } | ||
| } | ||
|
|
||
| export const lotusRepository = new LotusRepository(); | ||
|
|
||
| const insertLotus = () => { | ||
| lotusMockData.forEach((lotus) => { | ||
| lotusRepository.create(lotus); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
🙋 큰 문제는 아니지만 이게 레포지토리의 코드인지는 잘 모르겠네요 저는 서비스에 둘 것 같아요.
레포지토리는 데이터의 기본적인 조회,생성,수정, 삭제 정도만 해준다고 생각하거든요.
There was a problem hiding this comment.
서비스 계층이 lotus에만 필요할 것 같아가지고 고민이 되네요ㅠ lotus, user, history에도 통일성있게 모두 서비스 계층을 추가해야될 것 같은데.. 다 추가하는게 낫겟죠..?
Comment on lines
82
to
86
| author: { id: '1', nickname: 'js_master', profile: 'https://devblog.com/authors/js_master', gistUrl: '' }, | ||
| logo: '/image/exampleImage.jpeg', | ||
| link: 'https://devblog.com/articles/1000000001', | ||
| isPublic: false, | ||
| gistUrl: '' |
There was a problem hiding this comment.
🙋 유저 레포지토리를 만들었으니 기왕이면 유저 레포지토리를 통해서 유저데이터를 관리하면 좋겠네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
closed #204
📝작업 내용
💬리뷰 요구사항(선택)