-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Network모듈 테스트 #186
Open
futuremirae
wants to merge
11
commits into
develop
Choose a base branch
from
Test/NetworkTest/176
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Test] Network모듈 테스트 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hansangjin98
reviewed
Dec 6, 2024
Comment on lines
+12
to
+18
final class MockTokenManager: TokenManager { | ||
struct CallCount { | ||
var isAccessTokenValid = 0 | ||
var loadAccessToken = 0 | ||
var loadRefreshToken = 0 | ||
var storeToken = 0 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CallCount를 통해 호출만 테스트를 하려고 하신 것 같은데 테스트 과정에서 CallCount 체크가 이루어지는 것 같지 않네요!
또한 CallCount만 체크를 했을 때 올바른 테스트가 될지도 고민해봐야 할 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈 번호 ex) #이슈번호
📘 작업 유형
📙 작업 내역 (구현 내용 및 작업 내역을 기재합니다.)
📋 체크리스트 (PR을 올리기 전에 스스로 확인해봐요!)
📝 특이 사항 (Optional)