Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to display discarded products/variants. #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oneiros
Copy link

@oneiros oneiros commented Jan 18, 2019

First of all thanks for the wonderful plugin. We have been evaluating it and liked it a lot.

But we found one issue: When we delete a product in the admin backend that is still stored in a wishlist, there is an exception when trying to display that wishlist.

The reason is, that the product is not actually destroyed, but there is a deleted_at timestamp set. And there is a default scope for both Spree::Product and Spree::Variant that only queries records where deleted_at is NULL. That is why the variant stored in the wishlist can no longer be accessed.

The changes in this PR fix the issue for us. Of course, if you prefer another way to fix it, that is totally fine as well.

Thanks again and keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant