Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 135 update insights #153

Merged
merged 14 commits into from
Jul 1, 2022
Merged

Feat 135 update insights #153

merged 14 commits into from
Jul 1, 2022

Conversation

timrbula
Copy link
Member

@timrbula timrbula commented Jun 30, 2022 •
edited
Loading

Context

Related Issues(s):

Closes #135
Closes #141
Closes #142
Closes #143
Closes #145

Build Number: 3.9.4

Checklist:

  • Verified in an integrated environment
  • Unit and integration tests passing
  • Semantic HTML with accessibility support
  • No linting, test console, or browser console errors (best effort)
  • JSDoc comment blocks for complex code

PR Review Guidance

Major refactor and TSification of Insights feature

  • Update carbon charts
  • Add additional filters to match functionality of others app features
  • Improve performance of data formatting for charts (and new format)
  • Some overall cleanup and migration to some files to TS

Additional Info

@timrbula timrbula marked this pull request as ready for review June 30, 2022 22:03
@timrbula timrbula requested a review from tlawrie July 1, 2022 02:01
@tlawrie tlawrie merged commit 13dfb84 into main Jul 1, 2022
@tlawrie tlawrie deleted the feat-135-update-insights branch July 1, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlawrie tlawrie Awaiting requested review from tlawrie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Insights page
2 participants
@timrbula @tlawrie