Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat New Workflows Input Parameters #105

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LucasGrimauth
Copy link
Member

Context

Related Issues(s): ISEEC-2514

Build Number: 3.4.22

Checklist:

  • Verified in an integrated environment
  • Unit and integration tests passing
  • Semantic HTML with accessibility support
  • No linting, test console, or browser console errors (best effort)
  • JSDoc comment blocks for complex code

PR Review Guidance

Added Creatable, Creatable Pair, Date, Date Range and Multi Select parameters to workflows.

@tlawrie
Copy link
Member

tlawrie commented Nov 9, 2021

Thanks @LucasGrimauth. We need to map this to a GitHub issue in Roadmap as well.

The bigger part though that I think we need to go through is how these input types will be stored and handle by the Workflow Service, Controller Service, and Tasks. Any changes to Parameters can have an impact throughout the entire stack for Flow.

This analysis will need to be done prior to it being merged into the front-end.

@BenjaminRuby
Copy link
Member

Hey @tlawrie could you connect with @marcusdroy on your concerns here? This is something that we were hoping to add as part of our next core release to align the parameters in flow with what is available in core

@tlawrie
Copy link
Member

tlawrie commented Dec 6, 2021

Hi @BenjaminRuby sure this can be discussed at the next community meeting.

We will also need a github issue attached to 3.5.1. or 3.6.0

In terms of the technical discussion considering this is an IBM proposal, id suggest that the relevant technical details on both the front end and back end have to align and all of the information be in the GitHub issue. This means that if a Parameter type is introduced or changed on the front end, it has to be handled by the backend AND be able to be handled by Tekton. Which in this case, I'm not aware of any discussion or analysis being performed about how those would be passed through and understood by Tekton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants