fixed closure type inferrence in generic call context #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generic IEnumerable so linq methods does not work
…nsions for overload if instance member found even if it not applicable, for example property in call context
Conflicts: tests/testcases/integration/extensions/overload-resolution-extension.boo
|
Thanks. In the future, don't use Context.Environment.Provide() but My.Instance. |
|
ok. |
sharwell
pushed a commit
to sharwell/boo
that referenced
this pull request
Sep 16, 2015
Merge from Boo-linq
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ideal solution, compiler infer method signature two times first than select ambiguous (ProcessMethodBodies.cs line 4144) second than process method call (ProcessMethodBodies.cs line 4449)
it should be in one place, but code base is too complex for me for now.
It`s work, all tests passed and not ideal solution better than nothing.
Still broken:
closure type inference in constructor, I will try to fix it shortly
linq-extensions-2.boo parser think that in {i | i} body is method call