-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixer #72
Commits on Feb 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 080f4fc - Browse repository at this point
Copy the full SHA 080f4fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6453d4 - Browse repository at this point
Copy the full SHA e6453d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45b4214 - Browse repository at this point
Copy the full SHA 45b4214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7847f97 - Browse repository at this point
Copy the full SHA 7847f97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60d1740 - Browse repository at this point
Copy the full SHA 60d1740View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b0e8d - Browse repository at this point
Copy the full SHA 22b0e8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba04c0b - Browse repository at this point
Copy the full SHA ba04c0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 745e9b2 - Browse repository at this point
Copy the full SHA 745e9b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56c7e0e - Browse repository at this point
Copy the full SHA 56c7e0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3c022a - Browse repository at this point
Copy the full SHA a3c022aView commit details -
With `RunWithSuggestedFixes` we can assert that the output of the diagnostics created are corect. It's a bit weird because the golden file will contain all the expected assertions even though the would no longer be triggered. For now they're kept to make the test pass. Ref: https://godocs.io/golang.org/x/tools/go/analysis/analysistest#RunWithSuggestedFixes
Configuration menu - View commit details
-
Copy full SHA for 42258ce - Browse repository at this point
Copy the full SHA 42258ceView commit details
Commits on Feb 15, 2023
-
Add support to fix other than reported line
We can now fix a line that's not the one we reported. This is used when we have multiple cuddled vars but want to keep the last one since it's allowed (and required if error cuddling is forced). Also adds all the config flags
Configuration menu - View commit details
-
Copy full SHA for 182524d - Browse repository at this point
Copy the full SHA 182524dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c44041 - Browse repository at this point
Copy the full SHA 1c44041View commit details -
Add test case for advanced formatting
We currently only support adding a newline if we don't think vars should be cuddled. For `var` blocks we would ideally group them instead of separating by newline but this is currently not supported. This test only serves as an expectation of the fixer.
Configuration menu - View commit details
-
Copy full SHA for 9372cd9 - Browse repository at this point
Copy the full SHA 9372cd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07a9043 - Browse repository at this point
Copy the full SHA 07a9043View commit details -
* Remove newline in end of block * Remove newline in start of block (and comments...) This is WIP because we need to preserve the comments so they don't get deleted when we remove beginning of blocks.
Configuration menu - View commit details
-
Copy full SHA for eab3161 - Browse repository at this point
Copy the full SHA eab3161View commit details
Commits on Feb 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3491d2d - Browse repository at this point
Copy the full SHA 3491d2dView commit details
Commits on Feb 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5098be0 - Browse repository at this point
Copy the full SHA 5098be0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86d102f - Browse repository at this point
Copy the full SHA 86d102fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a216a31 - Browse repository at this point
Copy the full SHA a216a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for f27a3f0 - Browse repository at this point
Copy the full SHA f27a3f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86e1170 - Browse repository at this point
Copy the full SHA 86e1170View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ac306f - Browse repository at this point
Copy the full SHA 9ac306fView commit details
Commits on Feb 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0674abf - Browse repository at this point
Copy the full SHA 0674abfView commit details -
Add support for case blocks, update tests
* Work around case blocks * All tests now uses fixer * Different tests can set config per test
Configuration menu - View commit details
-
Copy full SHA for f15f90c - Browse repository at this point
Copy the full SHA f15f90cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3632854 - Browse repository at this point
Copy the full SHA 3632854View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37c13c3 - Browse repository at this point
Copy the full SHA 37c13c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 746e1b9 - Browse repository at this point
Copy the full SHA 746e1b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21ded97 - Browse repository at this point
Copy the full SHA 21ded97View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd12910 - Browse repository at this point
Copy the full SHA cd12910View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc8dfa4 - Browse repository at this point
Copy the full SHA fc8dfa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e30c94 - Browse repository at this point
Copy the full SHA 4e30c94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f07f21 - Browse repository at this point
Copy the full SHA 9f07f21View commit details
Commits on Feb 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cee7b81 - Browse repository at this point
Copy the full SHA cee7b81View commit details
Commits on Mar 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ff1beac - Browse repository at this point
Copy the full SHA ff1beacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97dc165 - Browse repository at this point
Copy the full SHA 97dc165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bd7017 - Browse repository at this point
Copy the full SHA 3bd7017View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02bf217 - Browse repository at this point
Copy the full SHA 02bf217View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.