Resolve some problem #532
Resolve some problem #532
Conversation
Add python-opencv as a dependency for ArchLinux
|
|
||
|
|
||
| def doAuth(pam_context): | ||
| """Starts authentication in a seperate process""" |
There was a problem hiding this comment.
[Misspell] "seperate" is a misspelling of "separate" (view)
| Rule | Correct | Incorrect |
|---|---|---|
separate |
separate | seperate |
You can close this issue if no need to fix it. Learn more.
| # Record a predetermined amount of frames from the camera | ||
| stream, ret = ( | ||
| ffmpeg | ||
| .input(self.device_path, format=self.device_format) |
There was a problem hiding this comment.
[Flake8] continuation line unaligned for hanging indent (view)
| Rule |
|---|
E131 |
You can close this issue if no need to fix it. Learn more.
| ) | ||
| self.video = ( | ||
| numpy | ||
| .frombuffer(stream, numpy.uint8) |
There was a problem hiding this comment.
[Flake8] continuation line unaligned for hanging indent (view)
| Rule |
|---|
E131 |
You can close this issue if no need to fix it. Learn more.
|
|
||
|
|
||
| u8_array = ctypes.c_uint8 * SIZE | ||
| data_maker = lambda v: uvc_ctrl_query(UNIT, SELECTOR, QUERY, SIZE, u8_array.from_buffer(v)) |
There was a problem hiding this comment.
[Flake8] do not assign a lambda expression, use a def (view)
| Rule |
|---|
E731 |
You can close this issue if no need to fix it. Learn more.
|
Hey, thank you for your work but i can not accept these changes as they are right now. You are very welcome to fix stuff but this is a monster of a PR with over 1000 changed lines, including edits to a library file that should not be edited. I would suggest that you find what exactly you want to fix, change only what you need to change and open a new PR describing what you've changed and why. I hope you understand that i can't manage huge PRs like this, simply look at the merge conflict list. |
|
Also, Howdy does not officially support non-IR cameras. A config option like |
|
OK, I will modify and resubmit But I don’t recommend using tab as indentation, This does not comply with the PEP8 specification |
Already fixed (tested on my computer)
#445
Not test
#458
#367
#312
#269
and I do something change