Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching decorated services #2987

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Add caching decorated services #2987

merged 2 commits into from
Dec 1, 2021

Conversation

I-Valchev
Copy link
Member

Fixes #2983

@bobdenotter
Copy link
Member

bobdenotter commented Nov 29, 2021 •
edited
Loading

Should we just add this to m_2021-11-22-services.yaml instead? They'll trigger at the same time, and they are pretty much related.

bobdenotter
bobdenotter approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@I-Valchev
Copy link
Member Author

(A bit delayed: but as discussed, yes I moved them to the services update related to caching, thanks!)

Joossensei
Joossensei approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@Joossensei Joossensei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

nestordedios
nestordedios approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@nestordedios nestordedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@I-Valchev I-Valchev merged commit cabeebb into master Dec 1, 2021
@I-Valchev I-Valchev deleted the enhancement/caching-services branch December 1, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

@nestordedios nestordedios nestordedios approved these changes

@Joossensei Joossensei Joossensei approved these changes

Assignees
No one assigned
Labels
tag: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add YAML migrations for decorators for caching
4 participants
@I-Valchev @bobdenotter @nestordedios @Joossensei