Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 'Remember me' by default, and make duration configurable #2911

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Enable 'Remember me' by default, and make duration configurable #2911

merged 2 commits into from
Nov 9, 2021

Conversation

bobdenotter
Copy link
Member

Note, the diff on src/Form/LoginType.php seems large, but apparently every line in that file was indented.

I-Valchev
I-Valchev approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This is so smart, me likes!

nestordedios
nestordedios approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator

@nestordedios nestordedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! 🎉 Looks good! 👍

@I-Valchev I-Valchev merged commit 268b78d into 5.0 Nov 9, 2021
@I-Valchev I-Valchev deleted the make-remember-me-configurable branch November 9, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nestordedios nestordedios nestordedios approved these changes

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
tag: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobdenotter @nestordedios @I-Valchev