Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Vue upgrade #2842

Draft
wants to merge 52 commits into
base: master
Choose a base branch
from
Draft

[WIP] Vue upgrade #2842

wants to merge 52 commits into from

Conversation

Joossensei
Copy link
Contributor

Working on upgrading from Vue 2 to Vue 3

@I-Valchev
Copy link
Member

Wow, awesome! Big fan of upgrading to Vue 3! 👍

@I-Valchev I-Valchev changed the base branch from master to 5.0 December 17, 2021 13:05
@I-Valchev I-Valchev changed the base branch from 5.0 to master December 17, 2021 13:05
@I-Valchev
Copy link
Member

Hi @Joossensei , solid progress!

A couple of questions I have:

  1. it looks like the Markdown field does not work for me:
    image

Am I missing something?

  1. Fields inside a set/collections are not working for me anymore, can you take a look?
    image

@Joossensei
Copy link
Contributor Author

Joossensei commented Jan 11, 2022

  • Fix the markdown
  • Fix the collections
  • Fix the tests

@Joossensei Joossensei marked this pull request as ready for review January 11, 2022 15:32
@Joossensei Joossensei marked this pull request as draft January 11, 2022 15:32
@Joossensei
Copy link
Contributor Author

@doenietzomoeilijk
Copy link
Contributor

@Joossensei is there any movement or outlook on movement here? The SO thread linked seems a bit dead. I'm kinda wondering, since I might have a go at getting the Markdown field going again (it looks like the current simplemde solution doesn't work so well anymore, there's a fork that still is under development and looks like a mostly-drop-in replacement, but I'm not sure if that'd clash with your work here.

@Joossensei
Copy link
Contributor Author

@doenietzomoeilijk You can always try! I didn't manage to figure out how to fix the Markdown field. But if you have an idea on how to fix it I won't stop you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants