Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restriction for (global) Composer 2 to composer.json #2614

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

bobdenotter
Copy link
Member

Fixes the issue where some people bumped into upgrade problems with vague descritpions, because they were still on composer 1.

If this is you, please upgrade to composer 2, by running composer selfupdate --2.

The main difference you'll notice is that Composer 2 is an order of magnitude faster than Composer 1 is.

@bobdenotter bobdenotter added the topic: DX Improving code quality, tests coverage, making codebase more intuitive label Jun 5, 2021
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I spotted something like this as well, wonder what causes it and if it is a breaking change?

@bobdenotter
Copy link
Member Author

if it is a breaking change?

Well, opinions differ.. Some people say raising requirements is fine within SemVer. Personally, I'm leaning towards considering bumping requirements as a BC break.

In this case, i don't think we have much choice. Our existing dependencies are causing breakage on existing installs. It basically requires an update to Composer 2. As in: If you don't update, it'll break in an obscure, hard to debug way.

This change makes the new requirement much more visible, and it will also prevent the breakage before it happens, in stead of afterwards.

Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobdenotter gotcha, thanks for explaining!

In that case, let's roll with this 👍

Copy link
Collaborator

@nestordedios nestordedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@I-Valchev I-Valchev merged commit b62bd4c into 4.1 Jun 10, 2021
@I-Valchev I-Valchev deleted the fix/ensure-we-are-using-composer-2 branch June 10, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants