Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix |filter and |order chaining returning no results #2603

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fix |filter and |order chaining returning no results #2603

merged 2 commits into from
Jun 2, 2021

Conversation

I-Valchev
Copy link
Member

FIxes #2601

bobdenotter
bobdenotter approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 👍

nestordedios
nestordedios approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@nestordedios nestordedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@bobdenotter bobdenotter merged commit f363ec1 into 4.1 Jun 2, 2021
@bobdenotter bobdenotter deleted the bugfix/filter-and-order-chaining branch June 2, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

@nestordedios nestordedios nestordedios approved these changes

@mcdennem mcdennem Awaiting requested review from mcdennem

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Pagerfanta (records) with Twig's |filter and Bolt's |order breaks
3 participants
@I-Valchev @bobdenotter @nestordedios