Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back some more files that we really do need. #2022

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

bobdenotter
Copy link
Member

No description provided.

Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less = more! 👍

@I-Valchev I-Valchev merged commit b2aba74 into master Oct 20, 2020
@I-Valchev I-Valchev deleted the bobdenotter-patch-1 branch October 20, 2020 07:44
@XWB
Copy link

XWB commented Oct 21, 2020

@bobdenotter Can you tag a new release, 4.1.2 is broken due to the absence of package.json

@bobdenotter
Copy link
Member Author

@XWB What is broken, exactly? I didn't think it was needed in normal use (except for when you're building the assets yourself, which I assume most people don't do)

@XWB
Copy link

XWB commented Oct 21, 2020

Our pipeline fails because it cannot find package.json since 4.1.2:

$ make build-assets
cd vendor/bolt/core && npm install && npm run build
npm WARN saveError ENOENT: no such file or directory, open 'vendor/bolt/core/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open 'vendor/bolt/core/package.json'
npm WARN core No description
npm WARN core No repository field.
npm WARN core No README data
npm WARN core No license field.
up to date in 0.313s
found 0 vulnerabilities
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path vendor/bolt/core/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open 'vendor/bolt/core/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/gitlab-runner/.npm/_logs/2020-10-21T11_15_21_125Z-debug.log
Makefile:20: recipe for target 'build-assets' failed
make: *** [build-assets] Error 254
Cleaning up file based variables
00:00
ERROR: Job failed: exit status 1

@bobdenotter
Copy link
Member Author

Why does your pipeline do this, instead of simply pulling in bolt/assets and/or running bin/console bolt:copy-assets ? saves a good minute or two each run.

@bobdenotter
Copy link
Member Author

@XWB We've tagged 4.1.3, but i'm still curious why you're doing it this way.. Not to say you shouldn't do this, but i'm always interested to learn about people's workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants