Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move npm jobs from Travis to Github Actions #1966

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

TomasVotruba
Copy link
Contributor

No description provided.

@TomasVotruba TomasVotruba changed the title tv ci stylelint [CI] Move npm jobs from Travis to Github Actions Oct 8, 2020
assets/js/app/common.js Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@TomasVotruba
Copy link
Contributor Author

2 less jobs for Travis CI 👍

Ready to merge ✔️

@TomasVotruba
Copy link
Contributor Author

CI fail is unrelated, random 1 fail of 3 behat jobs

@TomasVotruba
Copy link
Contributor Author

The space changes were moved to new pull-request, to make it easier to review
#1967

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Thanks yet again, @TomasVotruba 👍

@bobdenotter bobdenotter merged commit 45f3c60 into bolt:master Oct 12, 2020
@TomasVotruba TomasVotruba deleted the tv-ci-stylelint branch October 12, 2020 12:51
@TomasVotruba
Copy link
Contributor Author

👍

@TomasVotruba
Copy link
Contributor Author

The smalles possible jobs are now split on Github Actions. I guess there is ~3 minutes improvement now and the Travis only handles Behat content.

To analyse how to decouple the last bit, I'd need more time and learn about test structure.

I need to focus somewhere else (on Rector monorepo and phpdoc). So I suggest following, let's give it a month trial and then you ping me and give me a feedback, what needs to be improved.

If we feel in a good mood, we can try to move Behat as well and cut these 10 minutes to ~3.
What do you think:

@bobdenotter
Copy link
Member

I am all in favour of this gradual approach we've taken here. Improving one step at a time is a good way to work on Open Source projects. If we would change too sudden, there's always more chance of introducing unwanted side-effects. Taking this approach allows us to keep a better eye on it! 😇

If we feel in a good mood, we can try to move Behat as well and cut these 10 minutes to ~3.

Yes, eventually I think we should do that. If only because we can then get rid of Travis entirely. Simple math tells us the change of something breaking is lower when there's less cogs in the machine. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants