-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Move npm jobs from Travis to Github Actions #1966
Conversation
48248dc
to
390a2c2
Compare
2 less jobs for Travis CI 👍 Ready to merge ✔️ |
CI fail is unrelated, random 1 fail of 3 behat jobs |
f7dfd8b
to
e5da04d
Compare
The space changes were moved to new pull-request, to make it easier to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Thanks yet again, @TomasVotruba 👍
👍 |
The smalles possible jobs are now split on Github Actions. I guess there is ~3 minutes improvement now and the Travis only handles Behat content. To analyse how to decouple the last bit, I'd need more time and learn about test structure. I need to focus somewhere else (on Rector monorepo and phpdoc). So I suggest following, let's give it a month trial and then you ping me and give me a feedback, what needs to be improved. If we feel in a good mood, we can try to move Behat as well and cut these 10 minutes to ~3. |
I am all in favour of this gradual approach we've taken here. Improving one step at a time is a good way to work on Open Source projects. If we would change too sudden, there's always more chance of introducing unwanted side-effects. Taking this approach allows us to keep a better eye on it! 😇
Yes, eventually I think we should do that. If only because we can then get rid of Travis entirely. Simple math tells us the change of something breaking is lower when there's less cogs in the machine. ;-) |
No description provided.