Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix HTML DOM problems #1930

Merged
merged 1 commit into from
Oct 2, 2020
Merged

fix HTML DOM problems #1930

merged 1 commit into from
Oct 2, 2020

Conversation

LordSimal
Copy link
Contributor

As I looked through some of the TWIG templates my IDE (PHPStorm) marked some rather obvious HTML problems.

This PR cleans them up so at least these parts have valid HTML.

I did not add any containers or changed tags, I only moved mostly ending tags to the correct position or removed duplicate ending tags.

I-Valchev
I-Valchev approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Awesome, thank you for spotting and resolving this!

bobdenotter
bobdenotter approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LordSimal 👍

@bobdenotter bobdenotter merged commit a0bf561 into bolt:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LordSimal @bobdenotter @I-Valchev