Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename renderTemplate to render for consistency with AbstractController #1735

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Rename renderTemplate to render for consistency with AbstractController #1735

merged 2 commits into from
Aug 20, 2020

Conversation

bobdenotter
Copy link
Member

This one's for you, @mcdennem

I-Valchev
I-Valchev approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop! 👍

@mcdennem
Copy link
Member

Yesss!

@I-Valchev I-Valchev merged commit 6d838da into master Aug 20, 2020
@I-Valchev I-Valchev deleted the refactor/rename-renderTemplate-to-render branch August 20, 2020 07:31
@bobdenotter bobdenotter changed the title Rename renderTemplate to render for consistency with AbstractController Rename renderTemplate to render for consistency with AbstractController Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
🎩 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobdenotter @mcdennem @I-Valchev