Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error #1

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

maresb
Copy link

@maresb maresb commented Dec 14, 2022

No description provided.

@maresb
Copy link
Author

maresb commented Dec 14, 2022

Hmm, did I get the wrong base??? 🙁

@maresb maresb changed the base branch from main to gh-296-optional-gitpython December 14, 2022 22:13
@maresb
Copy link
Author

maresb commented Dec 15, 2022

@bollwyvl, does this look good? There were a few errors in the CI run for conda#298, but I suspect that they're only sporadic.

@bollwyvl
Copy link
Owner

bollwyvl commented Dec 15, 2022 via email

@maresb
Copy link
Author

maresb commented Dec 15, 2022

also Afk ... I suspect you need to rebase. I am not full maintainer so cannot commit to your branch

@maresb
Copy link
Author

maresb commented Dec 15, 2022

I suspect you need to rebase.

I was mistaken. Your main branch is behind, but this branch is up-to-date.

and get pip_support in there, too

Thank you for mentioning this! After vendoring Poetry in conda#240 I forgot to deprecate pip_support. Adding it to my todos with conda#299.

Then we could do multi-output for conda-forge

I'd personally like to avoid this if possible, since it makes the recipe complicated. Adding Git metadata is not default, so it seems more like a rare edge case to me. And with a loud and clear error message telling people to install GitPython, it seems to me like there's little room for confusion. What do you think?

@bollwyvl bollwyvl merged commit fe4e20a into bollwyvl:gh-296-optional-gitpython Dec 15, 2022
@maresb maresb deleted the fix-error branch December 15, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants