Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
When installing
react-rnd
usingYarn
, I got warnings like belowThis is due to
react-rnd
depends on an older version ofre-resizable
that hasn't includereact@v19
as peerDependency. So I would like to do this bump since I saw your change inre-resizable@6.10.3
.@bokuweb Please let me know if you need anymore context, but if you could take this change, that would be great!
Tradeoffs
I'm not fully aware of the internals of
re-resizable
norreact-rnd
, really naive about this change.Testing Done