Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump re-resizable@6.10.3 #957

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Bump re-resizable@6.10.3 #957

merged 2 commits into from
Dec 18, 2024

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Dec 18, 2024

Proposed solution

When installing react-rnd using Yarn, I got warnings like below

➤ YN0060: │ react is listed by your project with version 19.0.0 (p0f89c), which doesn't satisfy what re-resizable (via @finos/legend-art) and other dependencies request (but they have non-overlapping ranges!).

This is due to react-rnd depends on an older version of re-resizable that hasn't include react@v19 as peerDependency. So I would like to do this bump since I saw your change in re-resizable@6.10.3.

@bokuweb Please let me know if you need anymore context, but if you could take this change, that would be great!

Tradeoffs

I'm not fully aware of the internals of re-resizable nor react-rnd, really naive about this change.

Testing Done

@bokuweb
Copy link
Owner

bokuweb commented Dec 18, 2024

@akphi thanks!

@akphi
Copy link
Contributor Author

akphi commented Dec 18, 2024

Updated the lock file to fix the builds.

@bokuweb bokuweb merged commit 66b69a9 into bokuweb:master Dec 18, 2024
2 checks passed
@akphi akphi deleted the patch-1 branch December 18, 2024 06:29
@akphi
Copy link
Contributor Author

akphi commented Dec 18, 2024

@bokuweb thanks for merging! Do you mind cutting a release for this later? Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants