Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change yield(); to delay(0); because esp8266 2.4.0-rc2 wdt resets. #86

Closed
wants to merge 1 commit into from

Conversation

regimantas
Copy link

yield(); in esp8266 2.4.0-rc2 not prevent resets but delay(0); prevent. I install library in esp8266 and it non stop restarts until i change yield() to delay(0); and library start working :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
yield(); in esp8266 2.4.0-rc2 not prevent resets but delay(0); prevent. I install library in esp8266 and it non stop restarts until i change yield() to delay(0); and library start working :)
@amotl
Copy link
Contributor

amotl commented Feb 20, 2019

Thanks @regimantas , there have been some recent changes to this library incorporating things like coming from your suggestion. @bogde already verified the library would work on ESP8266 MCUs, so you should also be able to enjoy the current outcome.

As being superseded by merging #123, we might close this now.

@amotl
Copy link
Contributor

amotl commented Jul 14, 2019

Dear @regimantas and @bogde,

just revisiting this and I believe it might be closed. @regimantas: The updated library is available via Arduino Library Manager these days and should also work on ESP8266.

With kind regards,
Andreas.

@amotl
Copy link
Contributor

amotl commented Mar 4, 2021

Hi Bogdan,

thank you for responding to some open issues and closing them. I also believe we can close this PR as the respective improvements already have been integrated into the library.

Thanks again @regimantas for your initial contribution.

With kind regards,
Andreas.

@bogde bogde closed this Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants