Skip to content

Commit

Permalink
include output of failed shell command in error message (to help debu…
Browse files Browse the repository at this point in the history
…g failing test_toy_exts_parallel)
  • Loading branch information
boegel committed Feb 27, 2024
1 parent 4b63b91 commit 5230ff8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion easybuild/framework/easyblock.py
Original file line number Diff line number Diff line change
Expand Up @@ -2000,6 +2000,7 @@ def update_exts_progress_bar_helper(running_exts, progress_size):
installed_ext_names.append(ext.name)
update_exts_progress_bar_helper(running_exts, 1)
else:
sys.stderr.write(f"Installation of {ext.name} failed: {res.output}\n")
raise_run_shell_cmd_error(res)
else:
self.log.debug(f"Installation of extension {ext.name} is still running...")
Expand Down Expand Up @@ -4167,7 +4168,8 @@ def run_all_steps(self, run_test_cases):
except RunShellCmdError as err:
err.print()
ec_path = os.path.basename(self.cfg.path)
error_msg = f"shell command '{err.cmd_name} ...' failed in {step_name} step for {ec_path}"
error_msg = f"shell command '{err.cmd_name} ...' failed in {step_name} step for {ec_path}: "
error_msg += f"{err.output}"
raise EasyBuildError(error_msg)
finally:
if not self.dry_run:
Expand Down

0 comments on commit 5230ff8

Please sign in to comment.