Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: simpler release script #22

Merged
merged 1 commit into from
Jan 19, 2025
Merged

ci: simpler release script #22

merged 1 commit into from
Jan 19, 2025

Conversation

mohsen1
Copy link
Collaborator

@mohsen1 mohsen1 commented Jan 19, 2025

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Simplified the release process in scripts/make-release.sh by streamlining version management and changelog generation while improving safety through manual intervention requirements.

  • Switched from git-cliff to cargo-cliff for more reliable changelog generation
  • Removed automatic artifact building and SHA computation to reduce complexity
  • Added clearer user guidance for manual git push operations
  • Improved error handling with more descriptive messages
  • Simplified version validation by relying on regex check only

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile


# -- Step 1: Read current version from Cargo.toml --
# 2. Get the current version from Cargo.toml
CURRENT_VERSION="$(cargo pkgid | cut -d# -f2 | cut -d: -f2)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: cargo pkgid output format could change in future Cargo versions. Consider adding error handling if cut commands fail.

git-cliff --config cliff.toml --tag "v${NEW_VERSION}" --output CHANGELOG.md
# 4. Generate/Update CHANGELOG using cargo-cliff
# Make sure cargo-cliff is installed (cargo install cargo-cliff)
cargo cliff --tag "v${NEW_VERSION}" --output CHANGELOG.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: cargo cliff command will fail if not installed. Add check for cargo-cliff installation before using.

@mohsen1 mohsen1 merged commit 17fe37f into main Jan 19, 2025
18 checks passed
@mohsen1 mohsen1 deleted the simpler-release branch January 19, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant