Increase recursion limit #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes[1] to the Rust standard library are affecting[2] the nesting size of types to the point where typed-html can not be built on nightly. This resolves the issue by increasing the acceptable recursion depth for the crate. [1]: rust-lang/rust#70896 [2]: rust-lang/rust#71359 Closes: bodil#112
|
The CI failures so far seem all unrelated to the changes themselves. |
|
Closing in favour of #117. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes1 to the Rust standard library are affecting2 the nesting
size of types to the point where typed-html can not be built on nightly.
This resolves the issue by increasing the acceptable recursion depth for
the crate.
Closes: #112
Whether this is a cautionary does-no-harm change or an actual fix for an issue with newer version depends on how the underlying issue2 is resolved on Rust side. Possibly it's considered acceptable breakage (given overrides to the recursion limits are easy to fix, inherently depend on Rust compiler internals, and that the default is good enough for most cases), and then this is the mitigation to be applied in this crate.