Skip to content
This repository has been archived by the owner on Sep 3, 2019. It is now read-only.

Fix #1484 show full title on signle column #1491

Merged
merged 4 commits into from
Jun 19, 2019

Conversation

henryzbw
Copy link
Contributor

image
image

@henryzbw henryzbw self-assigned this Jun 17, 2019
Copy link
Member

@dwalintukan dwalintukan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks, LGTM

</div>
<div className={classes.eventCardInfoItem}>
<RaisedAmount amount={totalBets} />
<div className={classes.upper}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant you just add the CSS to eventCardSection?

Copy link
Contributor Author

@henryzbw henryzbw Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are taking all the stuff above options as one part, and options as another part, so I can add some space between these two parts, since on mobile size, it won't have height for the card. So the flex property doesn't have them separated.

@@ -47,6 +53,14 @@ const styles = (theme) => ({
fontSize: '1.05rem',
textAlign: 'left',
whiteSpace: 'nowrap',
[theme.breakpoints.down('xs')]: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be able to add the noWrap prop on Typography to handle ellipsizing it.
https://material-ui.com/api/typography/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is weird cause it already has ellipsis on the class. ya try using the material ui prop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, its intentionally to show all the title and not ellipsis it. TT want when it's on mobile size(only one card per row) we show full title like first pic, if its on larger screen(2 or 3 cards per row), we ellipsis the title.

@dwalintukan dwalintukan changed the base branch from master to development June 18, 2019 02:33
@dwalintukan
Copy link
Member

🚢

@henryzbw henryzbw merged commit 8708202 into development Jun 19, 2019
@henryzbw henryzbw deleted the show-full-title-on-single-column branch June 19, 2019 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants