updating toml++ to v3 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marzer
force-pushed
the
tomlpp-v3
branch
8 times, most recently
from
9027c0e to
2a5265c
Compare
|
Damn, your CI kicked my ass, lol. Took me 8 separate force-pushes before it came up green. |
|
@marzer yeah we are supporting quite a few platforms so haha sometimes people do get caught with it. |
|
@marzer And congratulation on beating rtoml :) wondering if you did some optimisation specifically on v3 side or it is simply using |
|
Thanks! I did a lot of work in the parser to eliminate a number of unnecessary string allocations, and added a SIMD fast-path to the unicode decoder. |
|
@bobfang1992 I released toml++ v3 earlier and have updated this PR accordingly. I'll let you do the honours ^_^ |
|
@marzer Hi, congratulations! Quite an achievement. I will merge this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bobfang1992 please don't merge this in just yet as toml++ v3 is still in development. I'm just using this PR as a hook into your CI to make sure things work OK. I'll update the PR when I release v3 properly ^_^