Skip to content

Commit

Permalink
Add more logging to the controller.
Browse files Browse the repository at this point in the history
Add logging to the controller so its clear when controller it done
waiting for informer caches to sync.
Do not watch for pipelines deletion in `PipelineRun` controller. We will
address it in #102
  • Loading branch information
tejal29 authored and knative-prow-robot committed Oct 5, 2018
1 parent e3f4ac4 commit f9d5590
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
1 change: 1 addition & 0 deletions cmd/controller/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ func main() {
}
}

logger.Info("Starting controllers")
// Start all of the controllers.
for _, ctrlr := range controllers {
go func(ctrlr *controller.Impl) {
Expand Down
7 changes: 0 additions & 7 deletions pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,6 @@ func NewController(
UpdateFunc: controller.PassNew(impl.Enqueue),
DeleteFunc: impl.Enqueue,
})

pipelineInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: impl.Enqueue,
UpdateFunc: controller.PassNew(impl.Enqueue),
DeleteFunc: impl.Enqueue,
})

return impl
}

Expand Down

0 comments on commit f9d5590

Please sign in to comment.