Skip to content

Commit

Permalink
Update conditions in example runs
Browse files Browse the repository at this point in the history
We don't yet have validation implemented for our Runs, but as of #86 we
are using the same Conditions as Knative Build: just `Succeeded` (where
unknown means running, true means it finished successfully and false
means it finished but failed)
  • Loading branch information
bobcatfish committed Oct 9, 2018
1 parent ef2e28a commit 739b486
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 24 deletions.
16 changes: 3 additions & 13 deletions examples/invocations/kritis-pipeline-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,8 @@ status:
- taskRef:
name: push-kritis-12321312984
conditions:
- type: Started
status: "True"
lastTransitionTime: "2018-10-04T12:25:39Z"
reason: manualTrigger
message: "Pipeline has been triggered manually"
- type: Completed
status: "True"
lastTransitionTime: "2018-10-04T13:25:39Z"
reason: done
message: "Pipeline execution has finished"
- type: Successful
- type: Succeeded
status: "False"
lastTransitionTime: "2018-10-04T13:25:39Z"
lastTransitionTime: "2018-10-04T12:25:39Z"
reason: taskFailure
message: "TaskRun `build-push-kritis-12321312984` had non-zero exit code"
message: "TaskRun `build-push-kritis-12321312984` had non-zero exit code"
12 changes: 1 addition & 11 deletions examples/invocations/run-kritis-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,8 @@ status:
logsURL: 'gcs://somebucket/results/tests/unit-test-kritis-feature-x/make'
exitCode: 0
conditions:
- type: Started
- type: Succeeded
status: "True"
lastTransitionTime: "2018-10-04T12:25:39Z"
reason: pipelineRun
message: "Task has been triggered by a Pipeline run"
- type: Completed
status: "True"
lastTransitionTime: "2018-10-04T13:25:39Z"
reason: done
message: "Pipeline execution has finished"
- type: Successful
status: "True"
lastTransitionTime: "2018-10-04T13:25:39Z"
reason: zeroExitCode
message: "All steps completed with an exit code of 0"

0 comments on commit 739b486

Please sign in to comment.